Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task][PD-109] Check usage of private vs protected methods and decide which classes should be final #7

Merged
merged 4 commits into from
Jan 30, 2024
Merged

[Task][PD-109] Check usage of private vs protected methods and decide which classes should be final #7

merged 4 commits into from
Jan 30, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Jan 30, 2024

Changes in this pull request

Resolves https://pimcore.atlassian.net/browse/PD-109

@lukmzig lukmzig added the Task label Jan 30, 2024
@lukmzig lukmzig added this to the 1.0.0 milestone Jan 30, 2024
@lukmzig lukmzig marked this pull request as ready for review January 30, 2024 06:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Qodana for PHP

1 new problem were found

Inspection name Severity Problems
Efferent coupling between objects ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

martineiber
martineiber approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lukmzig lukmzig merged commit 82b8793 into 1.x Jan 30, 2024
7 of 10 checks passed
@lukmzig lukmzig deleted the PD-109-protected-methods branch January 30, 2024 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukmzig @martineiber