Skip to content

Commit

Permalink
update php and pimcore, fix deprecations (#165)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexz707 authored Jan 17, 2025
1 parent 1d8804f commit 49442db
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 19 deletions.
7 changes: 0 additions & 7 deletions .github/ci/scripts/setup-pimcore-environment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,3 @@ chmod 755 bin/console
cp -r .github/ci/files/kernel/. kernel
cp -r .github/ci/files/public/. public

if [ ${REQUIRE_ADMIN_BUNDLE} = true ]; then
composer require -n --no-update pimcore/admin-ui-classic-bundle:^1.0
else
## Todo Remove when dropping support for Pimcore 10
rm config/packages/security.yaml
cp .github/ci/files/security.yaml config/packages
fi
8 changes: 3 additions & 5 deletions .github/workflows/codeception.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ jobs:
strategy:
matrix:
include:
- { php-version: 8.1, database: "mariadb:10.11", pimcore_version: "", dependencies: highest, experimental: false, require_admin_bundle: true }
- { php-version: 8.2, database: "mariadb:10.11", pimcore_version: "", dependencies: highest, experimental: false, require_admin_bundle: true }
- { php-version: 8.3, database: "mariadb:10.11", pimcore_version: "11.x-dev", dependencies: highest, experimental: true, require_admin_bundle: true }
- { php-version: 8.3, database: "mariadb:10.11", pimcore_version: "", dependencies: highest, experimental: false }
- { php-version: 8.4, database: "mariadb:10.11", pimcore_version: "", dependencies: highest, experimental: false }
- { php-version: 8.4, database: "mariadb:10.11", pimcore_version: "12.x-dev", dependencies: highest, experimental: true }
services:
mariadb:
image: "${{ matrix.database }}"
Expand Down Expand Up @@ -58,8 +58,6 @@ jobs:
done
- name: "Setup Pimcore environment"
env:
REQUIRE_ADMIN_BUNDLE: "${{ matrix.require_admin_bundle }}"
run: |
mysql -e "CREATE DATABASE pimcore_test CHARSET=utf8mb4;"
chmod 755 .github/ci/scripts/setup-pimcore-environment.sh
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
strategy:
matrix:
include:
- { php-version: "8.1", dependencies: "highest", pimcore_version: "", phpstan_args: "", experimental: false, require_admin_bundle: true }
- { php-version: "8.2", dependencies: "highest", pimcore_version: "", phpstan_args: "", experimental: false, require_admin_bundle: true }
- { php-version: "8.3", dependencies: "highest", pimcore_version: "11.x-dev", phpstan_args: "", experimental: true, require_admin_bundle: true }
- { php-version: "8.3", dependencies: "highest", pimcore_version: "", phpstan_args: "", experimental: false }
- { php-version: "8.4", dependencies: "highest", pimcore_version: "", phpstan_args: "", experimental: false }
- { php-version: "8.4", dependencies: "highest", pimcore_version: "12.x-dev", phpstan_args: "", experimental: true }
steps:
- name: "Checkout code"
uses: "actions/checkout@v2"
Expand All @@ -34,8 +34,6 @@ jobs:
php-version: "${{ matrix.php-version }}"

- name: "Setup Pimcore environment"
env:
REQUIRE_ADMIN_BUNDLE: "${{ matrix.require_admin_bundle }}"
run: |
.github/ci/scripts/setup-pimcore-environment.sh
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"minimum-stability": "dev",
"require": {
"pimcore/compatibility-bridge-v10": "^1.0",
"pimcore/admin-ui-classic-bundle": "^1.0",
"pimcore/pimcore": "^11.2",
"pimcore/admin-ui-classic-bundle": "^1.0 || 2.x-dev",
"pimcore/pimcore": "^11.2 || 12.x-dev",
"symfony/http-foundation": "^6.3"
},
"require-dev": {
Expand Down

0 comments on commit 49442db

Please sign in to comment.