Consistency checks

pimcore · Jun 3, 2024 · bc4120d · bc4120d
1 parent 055abf9
commit bc4120d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/src/Dependency/Controller/Element/CollectionController.php b/src/Dependency/Controller/Element/CollectionController.php
@@ -59,8 +59,8 @@ public function __construct(
     #[Get(
         path: self::API_PATH . '/dependencies/{elementType}/{id}',
         operationId: 'getDependencies',
-        description: 'Get paginated dependencies. 
-        Pass dependency mode to get either all elements that depend on the provided element 
+        description: 'Get paginated dependencies.
+        Pass dependency mode to get either all elements that depend on the provided element
         or all dependencies for the provided element.',
         summary: 'Get all dependencies for provided element.',
         security: self::SECURITY_SCHEME,

diff --git a/src/Request/ElementParameters.php b/src/Request/ElementParameters.php
@@ -21,6 +21,7 @@
 use Pimcore\ValueObject\Integer\PositiveInteger;
 use Symfony\Component\Validator\Constraints\NotBlank;
 use Symfony\Component\Validator\Constraints\Positive;
+use ValueError;
 
 /**
  * @internal
@@ -50,12 +51,15 @@ public function getId(): int
         return $this->id;
     }
 
-
+    /**
+     * @throws InvalidElementTypeException|ValueError
+     */
     private function validate(): void
     {
-        if (!in_array($this->type, ElementTypes::ALLOWED_TYPES)){
+        if (!in_array($this->type, ElementTypes::ALLOWED_TYPES)) {
             throw new InvalidElementTypeException($this->type);
         }
+
         new PositiveInteger($this->id);
     }
 }
diff --git a/src/Version/Controller/Element/CleanupController.php b/src/Version/Controller/Element/CleanupController.php
@@ -71,7 +71,8 @@ public function __construct(
     public function cleanupVersions(
         string $elementType,
         int $id,
-        #[MapQueryString] VersionCleanupParameters $parameters): JsonResponse
+        #[MapQueryString] VersionCleanupParameters $parameters
+    ): JsonResponse
     {
         return $this->jsonResponse(
             ['ids' => $this->versionService->cleanupVersions(new ElementParameters($elementType, $id), $parameters)]

diff --git a/src/Version/Controller/Element/CollectionController.php b/src/Version/Controller/Element/CollectionController.php
@@ -78,7 +78,8 @@ public function __construct(
     public function getVersions(
         string $elementType,
         int $id,
-        #[MapQueryString] CollectionParameters $parameters): JsonResponse
+        #[MapQueryString] CollectionParameters $parameters
+    ): JsonResponse
     {
         $collection = $this->versionService->getVersions(
             new ElementParameters($elementType, $id),