Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#179 Endpoint for deleting users and user-folders #118

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

martineiber
Copy link
Contributor

Changes in this pull request

Part of pimcore/studio-ui-bundle#179

Additional info

@martineiber martineiber marked this pull request as ready for review June 12, 2024 12:16
@martineiber martineiber requested a review from mattamon June 12, 2024 12:16
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks already good to me

src/Exception/ForbiddenException.php Outdated Show resolved Hide resolved
src/User/Controller/DeleteUserController.php Outdated Show resolved Hide resolved
src/User/Controller/DeleteUserFolderController.php Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martineiber martineiber merged commit c7fdeb7 into 1.x Jun 13, 2024
8 checks passed
@martineiber martineiber deleted the 179-delete-user-and-folder branch June 13, 2024 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants