[Improvement] Custom Reports tree endpoint #665
Conversation
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint # Conflicts: # src/CustomReport/Repository/CustomReportRepository.php
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
mcop1
changed the title
| * @throws InvalidQueryTypeException | ||
| */ | ||
| #[Route('/custom-reports/config/tree', name: 'pimcore_studio_api_report', methods: ['GET'])] | ||
| #[IsGranted(UserPermissions::TAGS_SEARCH->value)] |
There was a problem hiding this comment.
Is this the correct permission?
| * @throws InvalidQueryTypeException | ||
| */ | ||
| #[Route('/custom-reports/tree', name: 'pimcore_studio_api_report', methods: ['GET'])] | ||
| #[IsGranted(UserPermissions::TAGS_SEARCH->value)] |
There was a problem hiding this comment.
Is this the correct permission?
There was a problem hiding this comment.
Obviously not, had some questions about how permissions are working and wanted to add more endpoints first. But thanks for reminding me.
| */ | ||
| #[Schema( | ||
| title: 'Custom Report', | ||
| type: 'object' |
There was a problem hiding this comment.
Please add the required fields here. Like every field that is not nullable is required basically
There was a problem hiding this comment.
What does required in case of strings mean? Null or empty?
| */ | ||
| #[Schema( | ||
| title: 'Custom Report', | ||
| type: 'object' |
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
|
Thanks for reviewing, in general I would prefer reviews after a pull request is done and I "request" an review. Should we, for the future, use the draft option for that? |
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
|
Changes in this pull request
Resolves #660
Resolves #661
Additional info
Added 2 endpoints:
1.) Get reports to display in a tree, that is used to actually display the reports
2.) Get reports to display in a tree, that is used for configuring the reports