Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permissions and locked status to grid items #667

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open

Add permissions and locked status to grid items #667

wants to merge 6 commits into from

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jan 9, 2025

Changes in this pull request

Resolves #663

Additional info

Adding addtional infos to grid items

@mattamon mattamon mentioned this pull request Jan 9, 2025
Open
Corepex
Corepex requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we also have to update the schema definition in Grid/Attribute/Property/GridCollection.php or?

@mattamon mattamon requested a review from Corepex January 10, 2025 09:54
Corepex
Corepex requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would set isLocked and permissions required.
Please also add the id to the response (as required).

Corepex
Corepex approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work thx :D

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corepex Corepex Corepex approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add permissions to grid
2 participants
@mattamon @Corepex