Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Asset image add crop options to custom image thumbnail endpoint #718

Merged

Conversation

mcop1
Copy link
Contributor

@mcop1 mcop1 commented Jan 22, 2025

Changes in this pull request

Resolves #702

Additional info

@mcop1 mcop1 self-assigned this Jan 22, 2025
Copy link

sonarqubecloud bot commented Jan 22, 2025

@mcop1 mcop1 marked this pull request as ready for review January 22, 2025 12:26
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcop1 mcop1 merged commit 4710085 into 1.x Jan 22, 2025
12 checks passed
@mcop1 mcop1 deleted the 702-asset-image-add-crop-options-to-custom-image-thumbnail-endpoint branch January 22, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
@mcop1
Copy link
Contributor Author

mcop1 commented Jan 22, 2025

Only thing I noticed is that, at some point, we could split up src/Asset/MappedParameter/ImageDownloadConfigParameter.php dto a bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Asset Image] Add crop options to custom image thumbnail endpoint
2 participants