Fix issues with --synthetic_metadata parsing, expand examples #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--synthetic_metadata` was not parsed correctly if multiple instances of synthetic_metadata were passed, due to the use of lambdas in the metadata generator parser - they captured the initial value of the arguments passed, which had the effect of subsequent --synthetic_metadata fields using the "wrong" values. Fix by replacing these with normal functions; then add tests to cover each metadata field type. Also expand the documentation for synthetic metadata, hopefully make it easier for users to make use of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--synthetic_metadatawas not parsed correctly if multiple instances of synthetic_metadata were passed, due to the use of lambdas in the metadata generator parser - they captured the initial value of the arguments passed, which had the effect of subsequent --synthetic_metadata fields using the "wrong" values.Solution
Fix by replacing these with normal functions; then add tests to cover each metadata field type.
Also expand the documentation for synthetic metadata, hopefully make it easier for users to make use of.
Type of Change