-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Assistant code to RC branch #322
base: release-candidate/2025-01
Are you sure you want to change the base?
Conversation
… to Assistant feat. branch (#315) For an unknown-as-of-right-now reason, the Typescript `fetch` generator has been failing non-deterministically to generate code. We successfully got it to generate on a new branch, so this PR simply merges the generated code to the existing Assistant feature branch. I will hunt around online to see if I can find any open Github issues that might reveal what's going on w/the `fetch` generator... [Note the only diff btwn these 2 branches is the generated code, isolating the generation issues to the generator itself, not to files in our client repo.]
'~5.3.0', | ||
'~5.4.0', | ||
'~5.5.0', | ||
'~5.6.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this Slack thread for more color on this change
assistantName: ${{ steps.step3.outputs.ASSISTANT_NAME }} | ||
testFile: ${{ steps.step3.outputs.TEST_FILE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reviewers: You can ignore these diffs if you like. It's just me allowing CI to spin up a global Assistant and a file to play with.
Description
This PR adds the code necessary to use Assistant via our Node SDK.
There are many moving parts here, so I will only call out the most impt:
setup
andteardown
files to call/update a centralized Assistant in order to use our resources wisely (just like the core DB does with its data plane int. tests)assistantHostSingleton
) much like the core DB code does withindexHostSingleton
getHostUrl
in the above-mentioned Singleton. This determines which host (between theeu
URL and theus
URL) to route the data plane calls to. If unable to determine this host, the Singleton defaults it to theus
URL.A few things to call out for the future:
chat
andchatCompletion
are essentially the same code with different interface names. The feature team tells me this is becausechat
is very likely to diverge in the near-time fromchatCompletion
with the addition of Pinecone-specific featuresMisc.:
This PR includes removing support for Typescript versions <
4.5
, since we were running into errors with those versions and aim to maintain a 2-ish year sliding window for which versions we support. Everything pre-v4.5
was published in ~2021, so is quite old.Basic usage
Control plane stuffs
Data plane stuffs
Type of Change
Test Plan
CI passes.