Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add ruff lint and format on git hook and github action #571

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

Mini256
Copy link
Member

@Mini256 Mini256 commented Jan 6, 2025

Rye uses Ruff for linting and formatting. Unfortunately, the official rye lint and rye format commands do not come with corresponding pre-commit hooks or GitHub Actions (Related issue: astral-sh/rye#1095). However, we can use Ruff's pre-commit hooks and GitHub Actions to implement test checks.

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidb-ai-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:35am
tidb-ai-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:35am

@Mini256 Mini256 changed the title Add rye format on hook Add ruff lint and format on git hook and github action Jan 6, 2025
@Mini256 Mini256 requested review from wd0517 and Icemap January 6, 2025 07:37
@Mini256 Mini256 changed the title Add ruff lint and format on git hook and github action .github: add ruff lint and format on git hook and github action Jan 6, 2025
@Mini256 Mini256 changed the title .github: add ruff lint and format on git hook and github action chore(ci): add ruff lint and format on git hook and github action Jan 6, 2025
@Mini256 Mini256 merged commit 314441d into main Jan 6, 2025
9 checks passed
@Mini256 Mini256 deleted the add-rye-format-on-hook branch January 6, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants