Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix move table API #906

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Jan 17, 2025

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

This pull request enhances the move table API to automatically locate the maintainer’s server and forward the request, simplifying user operations. It also fixes the move table integration test case.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen asddongmen marked this pull request as ready for review January 19, 2025 13:17
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2025
@asddongmen asddongmen self-assigned this Jan 19, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 20, 2025
Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-20 00:58:59.514419042 +0000 UTC m=+56066.845338438: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit eee5de2 into pingcap:master Jan 20, 2025
28 of 29 checks passed
@asddongmen asddongmen deleted the fix_move_table branch January 22, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants