Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix intetragion test case changefeed_fast_fail #916

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Jan 20, 2025

What problem does this PR solve?

Issue Number: close #915 #914 ref #442

What is changed and how it works?

This pull request accomplishes the following:

  1. Fixes the integration test case changefeed_fast_fail.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2025
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2025
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen asddongmen changed the title *: fix changefeed fast failed *: fix several bugs and intetragion test cases Jan 20, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2025
@asddongmen asddongmen marked this pull request as ready for review January 20, 2025 07:44
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@asddongmen asddongmen force-pushed the fix_changefeed_fast_fail branch from 0af35a4 to def832b Compare January 20, 2025 09:23
@asddongmen asddongmen changed the title *: fix several bugs and intetragion test cases test: fix intetragion test case changefeed_fast_fail Jan 20, 2025
@asddongmen asddongmen force-pushed the fix_changefeed_fast_fail branch 2 times, most recently from 9220d79 to dec2648 Compare January 20, 2025 09:28
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2025
Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 20, 2025
Copy link

ti-chi-bot bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-20 09:32:37.850293853 +0000 UTC m=+86885.181213251: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 20, 2025
@asddongmen
Copy link
Collaborator Author

/check-issue-triage-complete

@asddongmen
Copy link
Collaborator Author

/merge

Copy link

ti-chi-bot bot commented Jan 20, 2025

@asddongmen: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 30220bf into pingcap:master Jan 20, 2025
23 of 27 checks passed
@asddongmen asddongmen deleted the fix_changefeed_fast_fail branch January 22, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changefeed can't not be deleted
2 participants