Skip to content

Commit

Permalink
reset memory_usage_high_water
Browse files Browse the repository at this point in the history
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
  • Loading branch information
CalvinNeo committed Jan 2, 2025
1 parent 533d26d commit 0208558
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion proxy_components/proxy_server/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,14 @@ impl Default for ProxyConfig {
raftdb: RaftDbConfig::default(),
storage: StorageConfig::default(),
enable_io_snoop: false,
memory_usage_high_water: 0.1,
// Previously, we set `memory_usage_high_water` to 0.1, in order to make TiFlash to be
// always in a high-water situation. thus by setting
// `evict_cache_on_memory_ratio`, we can evict entry cache if there is a memory usage
// peak after restart. However there're some cases that the raftstore could
// take more than 5% of the total used memory, so TiFlash will reject
// msgAppend to every region. So, it actually not a good idea to make
// TiFlash Proxy always run in a high-water state, in order to reduce the
// memory usage peak after restart.
readpool: ReadPoolConfig::default(),
import: ImportConfig::default(),
engine_store: EngineStoreConfig::default(),
Expand Down

0 comments on commit 0208558

Please sign in to comment.