forked from tikv/tikv
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI: add two empty implement FFI for compatibility #361
Merged
Lloyd-Pottiger
merged 10 commits into
pingcap:raftstore-proxy
from
Lloyd-Pottiger:disagg-encryption-at-rest
Jan 18, 2024
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3b44950
FFI: add two empty implement FFI
Lloyd-Pottiger 9772655
add description
Lloyd-Pottiger 7ff31ce
move into a struct
Lloyd-Pottiger 43bbb2f
move to CloudStorageEngineInterfaces
Lloyd-Pottiger 3b46b7c
fmt
Lloyd-Pottiger e106fbc
update version
Lloyd-Pottiger 2eb539e
f
Lloyd-Pottiger 71ae19b
f
Lloyd-Pottiger 3578470
merge master
Lloyd-Pottiger 7db9e28
update version
Lloyd-Pottiger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,6 +65,8 @@ impl RaftStoreProxyFFIHelper { | |
fn_handle_new_file: Some(ffi_handle_new_file), | ||
fn_handle_delete_file: Some(ffi_handle_delete_file), | ||
fn_handle_link_file: Some(ffi_handle_link_file), | ||
fn_get_keyspace_encryption: Some(CloudStorageEngineFFI::ffi_get_keyspace_encryption), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we also put these two ffis into one struct, like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
fn_get_master_key: Some(CloudStorageEngineFFI::ffi_get_master_key), | ||
fn_handle_batch_read_index: Some(ffi_batch_read_index), | ||
sst_reader_interfaces: SSTReaderInterfaces { | ||
fn_get_sst_reader: Some(ffi_make_sst_reader), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility for whom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cse, https://github.com/tidbcloud/cloud-storage-engine/pull/1167