Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deprecated] Adapt to TiKV's raft grpc message filter #413

Closed
wants to merge 11 commits into from
Closed

[deprecated] Adapt to TiKV's raft grpc message filter #413

wants to merge 11 commits into from

Conversation

CalvinNeo
Copy link
Member

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

cfzjywxk and others added 10 commits January 13, 2025 10:13
@cfzjywxk
txn: fix duplicate locks returned in scan locks (tikv#18115)
8fc44fe 
close tikv#16818

Fix duplicated keys returned scanning locks.

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@zyguan
txn: prevent 1pc locks from being skipped when reading with max-ts (t…
85d583c 
…ikv#18095)

close tikv#18117

Introduce a new field `use_one_pc` to the `Lock` struct to indicate whether the txn uses 1pc, and use it to prevent locks from being skipped when reading with max-ts.

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@overvenus @ti-chi-bot
*: extend task wait metrics and add configuration description (tikv#1…
c9c91b6 
…8099)

ref tikv#15990

* Increase task wait metrics upper limit from 2.5s to 42s to capture
  long task wait records that are crucial for investigating high
  latency issues
* Add description for end-point-memory-quota configuration

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@cfzjywxk
coprocessor: fix the check logic of external request (tikv#18128)
a863bdb 
ref tikv#14474

Fix the request source check logic for external or internal

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@LykxSassinator
rocksdb: resolve flow control issues caused by clock-skew problems. (t…
d4bc987 
…ikv#18102)

close tikv#17995

Address clock-skew issues.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@Connor1996
*: Fix incorrect mapped allocation per thread metric (tikv#18126)
18f4419 
close tikv#18125

Fix incorrect mapped allocation per thread metric

Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@wshwsh12 @ti-chi-bot
expr: support scalar function from_unixtime in tikv (tikv#18112)
d43fea7 
close tikv#18111

Support scalar function from_unixtime in tikv

Signed-off-by: wshwsh12 <793703860@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@CalvinNeo @ti-chi-bot @glorv
Support customized raft message rejection logic (tikv#18114)
c88260c 
close tikv#18113

Support customized raft message rejection logic

Signed-off-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: glorv <glorvs@163.com>
@CalvinNeo @MyonKeminta @ekexium
Update proxy to TiKV(2f3f32d) (pingcap#412)
6b553bd 
 

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: MyonKeminta <9948422+MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>
@CalvinNeo
Merge remote-tracking branch 'tikv/master' into u-mem
a89e7c1
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from calvinneo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 20, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 7 committers have signed the CLA.

✅ CalvinNeo
✅ wshwsh12
❌ cfzjywxk
❌ zyguan
❌ LykxSassinator
❌ Connor1996
❌ overvenus
You have signed the CLA already but the status is still pending? Let us recheck it.

@CalvinNeo CalvinNeo changed the title Adapt to TiKV's raft grpc message observer Adapt to TiKV's raft grpc message filter Jan 21, 2025
@CalvinNeo CalvinNeo added the tide/merge-method-merge merge method merge label Jan 21, 2025
@CalvinNeo
Copy link
Member Author

/retest

1 similar comment
@CalvinNeo
Copy link
Member Author

/retest

@CalvinNeo
adapt
3f2efb3 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

@CalvinNeo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 3f2efb3 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JaySon-Huang
Copy link
Collaborator

Seems that most commits has been merged to raftstore-proxy by #412 . But those commit still present in this PR. This is confusing.

Maybe reset the base of your branch to the latest raftstore-proxy and pick the commit you changed?

@CalvinNeo
Copy link
Member Author

Seems that most commits has been merged to raftstore-proxy by #412 . But those commit still present in this PR. This is confusing.

Maybe reset the base of your branch to the latest raftstore-proxy and pick the commit you changed?

It is because the former commit is stashed committed...

@CalvinNeo
Copy link
Member Author

/hold

@CalvinNeo CalvinNeo closed this Jan 22, 2025
@CalvinNeo CalvinNeo reopened this Jan 22, 2025
@CalvinNeo CalvinNeo closed this Jan 22, 2025
@CalvinNeo CalvinNeo changed the title Adapt to TiKV's raft grpc message filter [deprecated] Adapt to TiKV's raft grpc message filter Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
do-not-merge/hold size/XXL tide/merge-method-merge merge method merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@CalvinNeo @CLAassistant @JaySon-Huang @cfzjywxk @zyguan @overvenus @LykxSassinator @Connor1996 @wshwsh12