I18N-1195: Trigger BranchStatsJob when Branch is created #209
+38
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronantak
force-pushed
the
feat/trigger-repo-stats-on-branch-create
branch
from
266b7ba to
54ac1f3
Compare
byronantak
force-pushed
the
feat/trigger-repo-stats-on-branch-create
branch
from
54ac1f3 to
1968b16
Compare
byronantak
changed the title
byronantak
force-pushed
the
feat/trigger-repo-stats-on-branch-create
branch
from
1968b16 to
3110b2d
Compare
byronantak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when a branch is created, the stats for the branch would only be created when a RepoStats Job is run. This would only happen when a text unit is updated in the DB.
Problem: for smaller repos which do not update text units often, this would mean a branch notification would only be sent much later
Now, we trigger a compute branch stats on branch create so that the branch gets notified as soon as possible