Answer to paused simucalst stream correctly #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
=======================================
Coverage 76.41% 76.42%
=======================================
Files 87 87
Lines 9879 9895 +16
=======================================
+ Hits 7549 7562 +13
- Misses 1860 1863 +3
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Answer to paused simucalst stream correctly
cnderrauber
force-pushed
the
paused_simulcast
branch
from
cec0511 to
949f010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the publisher sends an offer with paused simulcast stream like
a=simucalst:send 1;~2;~3, the sfu needs to respond with paused stream too, otherwise, it will make the publisher's inactive encoding to become active unintentionally.Reference issue
Fixes #...