This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Extract support project for shared code (method redirection) #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was shared code in the three core projects, UIKit, Foundation, and CoreLocation, all dealing with method redirection (swizzling). This PR extracts the functionality to
PCKMethodRedirector
in a new top-level project, Support. The three core projects then depend on this new project for their method swizzling.The extractions required quite a bit of changes to the existing dependency management.
PCKMethodRedirector.o
is the same and not link it in twice.@idoru and I kicked off the initial extraction and I took it from there. Let's think of this PR as the beginning of a discussion as I am sure this will require some more work to be done before emerging.