Hardening suggestions for python-security / safe_urlopen #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| @@ -58,7 +58,7 @@ def get( | |||
| **kwargs, | |||
| ): | |||
| UrlParser(url).check(allowed_protocols, host_validator) | |||
| return unsafe_get(url, params=params, **kwargs) | |||
| return unsafe_get(url, params=params, **kwargs, timeout=60) | |||
There was a problem hiding this comment.
Add timeout to requests call
| @@ -70,4 +70,4 @@ def post( | |||
| **kwargs, | |||
| ): | |||
| UrlParser(url).check(allowed_protocols, host_validator) | |||
| return unsafe_post(url, data=data, json=json, **kwargs) | |||
| return unsafe_post(url, data=data, json=json, **kwargs, timeout=60) | |||
There was a problem hiding this comment.
Add timeout to requests call
| @@ -58,7 +58,7 @@ def get( | |||
| **kwargs, | |||
| ): | |||
| UrlParser(url).check(allowed_protocols, host_validator) | |||
| return unsafe_get(url, params=params, **kwargs) | |||
| return unsafe_get(url, params=params, **kwargs, timeout=60) | |||
There was a problem hiding this comment.
Switch use of requests for security.safe_requests
| @@ -13,6 +13,7 @@ description = "The security toolkit for the Python community" | |||
| keywords = ["security", "appsec"] | |||
| dependencies = [ | |||
| "requests", | |||
| "security==1.2.1", | |||
There was a problem hiding this comment.
This library holds security tools for protecting Python API calls.
License: MIT ✅ Open Source ✅ More facts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (20 - Fix tests and add lint and test workflows) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot