Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9771 Move ORCID functionality into core application #684

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

ewhanson
Copy link
Contributor

No description provided.

@ewhanson ewhanson marked this pull request as ready for review May 23, 2024 19:18
Copy link
Contributor

@bozana bozana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ewhanson, also here:
What about PublishReviewerWorkToOrcid for OPS? -- The job is dispatched in the PKP-LIB in ThankReviewerForm.
(Theoretically reviews could be published in OMP and OPS, right? Is it the same format? How was it in the OPS plugin till now?)
Else, all fine :-)

@ewhanson
Copy link
Contributor Author

ewhanson commented Jun 3, 2024

Thanks @bozana, I've changed how the review job is handled. I've followed the same pattern from the deposit submission job (where there's a base action class in pkp-lib that's overwritten in each application to handle the reviews). Currently OJS is the only app that supports depositing reviews, but if we add it to OMP, we can revisit the job and see if there's any overlap between journal articles reviews and monograph reviews for ORCID.

@ewhanson ewhanson force-pushed the orcid branch 4 times, most recently from b22bc4c to 6e2f4d0 Compare June 7, 2024 22:43
@ewhanson ewhanson merged commit 6c94a9a into pkp:main Jun 21, 2024
8 checks passed
@ewhanson ewhanson deleted the orcid branch June 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants