Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix arm64 image and generate multiarch manifests #99

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

joemiller
Copy link
Member

goreleaser was creating an arm64 image containing the correct arm64 build of ghcommit but the rest of the packages (eg: /usr/bin/git) were amd64 binaries. Fix this by using buildx and explicitly setting --platform to linux/arm64

also we were not yet creating multi-arch manifests so downstream consumers would need to explicitly pull the <tag>-arm64 tag variants. this should no longer be necessary with the creation of multi-arch manifests

re:

goreleaser was creating an arm64 image containing the correct arm64
build of `ghcommit` but the rest of the packages (eg: /usr/bin/git) were
amd64 binaries. Fix this by using buildx and explicitly setting
--platform to linux/arm64

also we were not yet creating multi-arch manifests so downstream
consumers would need to explicitly pull the `<tag>-arm64` tag variants.
this should no longer be necessary with the creation of multi-arch
manifests
@joemiller joemiller requested a review from a team as a code owner January 13, 2025 21:50
@joemiller joemiller merged commit 5d23360 into main Jan 13, 2025
6 checks passed
@joemiller joemiller deleted the joem/goreleaser-multi-arch-docker-manifest branch January 13, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants