Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: eslint various #959

Merged
merged 10 commits into from
Jan 16, 2025
Merged

refactor: eslint various #959

merged 10 commits into from
Jan 16, 2025

Conversation

ksted
Copy link
Contributor

@ksted ksted commented Jan 15, 2025

Why:

Follow-up to #876

Describe your changes

Enables the following rules:

  • no-console
  • no-useless-escape
  • @typescript-eslint/ban-ts-comment
  • @typescript-eslint/no-dynamic-delete
  • @typescript-eslint/no-empty-object-type
  • @typescript-eslint/no-extraneous-class
  • @typescript-eslint/no-invalid-void-type
  • @typescript-eslint/no-namespace
  • @typescript-eslint/no-require-imports
  • vue/no-export-in-script-setup

Disables the rules in specific occurrences and resolves the remaining violations.

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

ksted added 8 commits January 15, 2025 08:22
- no-console
- no-useless-escape
- @typescript-eslint/ban-ts-comment
- @typescript-eslint/no-dynamic-delete
- @typescript-eslint/no-empty-object-type
- @typescript-eslint/no-extraneous-class
- @typescript-eslint/no-invalid-void-type
- @typescript-eslint/no-namespace
- @typescript-eslint/no-require-imports
- vue/no-export-in-script-setup
- no-console
- @typescript-eslint/no-extraneous-class
- @typescript-eslint/no-namespace
- @typescript-eslint/no-require-imports
@ksted ksted marked this pull request as ready for review January 15, 2025 07:42
@ksted ksted requested a review from a team as a code owner January 15, 2025 07:42
@ksted ksted merged commit e9490b3 into main Jan 16, 2025
10 of 11 checks passed
@ksted ksted deleted the refactor/eslint-various branch January 16, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants