Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use route in middleware #962

Merged
merged 9 commits into from
Jan 16, 2025
Merged

fix: use route in middleware #962

merged 9 commits into from
Jan 16, 2025

Conversation

N-Feist
Copy link
Contributor

@N-Feist N-Feist commented Jan 16, 2025

Why:

Closes: [AB#143662]

Describe your changes

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@N-Feist N-Feist requested a review from a team as a code owner January 16, 2025 07:41
@github-actions github-actions bot added the fix Patch a bug label Jan 16, 2025
@github-actions github-actions bot added the feature New feature or request label Jan 16, 2025
Copy link
Contributor

@csandru-plenty csandru-plenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this line please, from TextContent.vue (triggers a console warning while yarn setup:unix & yarn dev):

import { defineProps, computed } from 'vue';

apps/web/middleware/category-guard.ts Outdated Show resolved Hide resolved
@N-Feist N-Feist merged commit 233ce02 into main Jan 16, 2025
10 of 11 checks passed
@N-Feist N-Feist deleted the fix/useRoute-in-middleware branch January 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request fix Patch a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants