Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a components chapter #1367

Merged
merged 17 commits into from
Nov 13, 2024
Merged

a components chapter #1367

merged 17 commits into from
Nov 13, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented Dec 2, 2022

No description provided.

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 6be5b1c
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/660c5f9d6366ff0008e6e357
😎 Deploy Preview https://deploy-preview-1367--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jensens jensens changed the title intro for a components chapter a components chapter Dec 2, 2022
@stevepiercy
Copy link
Contributor

@jensens this PR needs to be based against 6.0, conflicts resolved, and moved out of Draft status. What do you need to push this forward? Please let me know. Thank you!

@jensens
Copy link
Member Author

jensens commented Apr 2, 2024

Well, I forgot about this one ...
I have no idea why I forgot about this chapter.

What I need? Time.
It seems conflicts are in the glossary: it should be solvable.

It is unfinished. If nobody steps up to continue it, I will look at it when I have time to do so.

@stevepiercy stevepiercy changed the base branch from 6-dev to 6.0 April 2, 2024 19:32
@stevepiercy
Copy link
Contributor

Rebased to 6.0, and resolved merge conflicts.

I'll trade you some of more free time for some of your knowledge. 😁

@stevepiercy
Copy link
Contributor

@jensens we've started new guides in documentation, and this seems to be mostly a Conceptual guide. I'd like to move it there, then review this PR. What else needs to happen in this PR?

@jensens
Copy link
Member Author

jensens commented Nov 6, 2024

@jensens we've started new guides in documentation, and this seems to be mostly a Conceptual guide. I'd like to move it there, then review this PR. What else needs to happen in this PR?

The last three sections need some content.

@stevepiercy
Copy link
Contributor

@jensens maybe we break this PR into smaller chunks? It's OK if it's not perfect or complete. We can place TODOs in incomplete sections, and create issues so we remember to fill in the blanks. Also if we have sources from previous versions of the docs, we can at least link to them, and eventually port them to Plone 6. Sorry, I'm not a content expert, but I can at least organize and be a cheerleader.

@jensens
Copy link
Member Author

jensens commented Nov 9, 2024

@stevepiercy yes, this is fine.

@stevepiercy
Copy link
Contributor

I've completed my revisions, added some todos, and created an issue at #1775.

I'll merge as soon as it is green. Thank you, @jensens, this is a great start.

@stevepiercy stevepiercy marked this pull request as ready for review November 13, 2024 11:36
@stevepiercy stevepiercy merged commit c81a125 into 6.0 Nov 13, 2024
3 checks passed
@stevepiercy stevepiercy deleted the components branch November 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants