Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX For Typos #826

Merged
merged 4 commits into from
Dec 14, 2023
Merged

FIX For Typos #826

merged 4 commits into from
Dec 14, 2023

Conversation

ujjwaleee26
Copy link
Contributor

@ujjwaleee26 ujjwaleee26 commented Dec 13, 2023 •
edited
Loading

Changes in doucmentation to fix issue #825

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for plone-training ready!

Name Link
🔨 Latest commit 8a5ae57
🔍 Latest deploy log https://app.netlify.com/sites/plone-training/deploys/657ad0b8dd667f0008622591
😎 Deploy Preview https://deploy-preview-826--plone-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ujjwaleee26
Copy link
Contributor Author

I have some, basic typos , which I felt necessary like boton-->button , beeing-->being,and other. Can I get a review please.

stevepiercy
stevepiercy requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my requested changes.

docs/mastering-plone-5/behaviors_1.md Outdated Show resolved Hide resolved
docs/mastering-plone-5/dexterity_reference.md Outdated Show resolved Hide resolved
docs/mastering-plone-5/dexterity_reference.md Outdated Show resolved Hide resolved
docs/mastering-plone/features.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

Please edit your description to include a magic GitHub keyword that will automatically close the referenced open issue when this PR is merged. Thank you!

ujjwaleee26 and others added 2 commits December 14, 2023 15:18
@ujjwaleee26 @stevepiercy
Update docs/mastering-plone-5/behaviors_1.md
8afed5a 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@ujjwaleee26
fix-plone#825
8a5ae57
@stevepiercy
Copy link
Contributor

Changes in doucmentation to fix issue #825

issue is not a keyword, so this will not automatically close it. The format must be KEYWORD #ISSUE-NUMBER, as the helpful link I provided earlier demonstrates.

stevepiercy
stevepiercy approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stevepiercy stevepiercy merged commit 336f9b0 into plone:main Dec 14, 2023
5 checks passed
@stevepiercy stevepiercy mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujjwaleee26 @stevepiercy