Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TCO): missing ticket_tco field in table object #397

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(TCO): missing ticket_tco field in table object #397

wants to merge 5 commits into from

Conversation

MyvTsv
Copy link

@MyvTsv MyvTsv commented Oct 25, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.

Description

  • It fixes !34818
  • adds the ticket_tco field to the table of each object when the user wants to use tickets. This fixes the bug that prevent TCO from being calculated for genericobject.

@stonebuzz stonebuzz requested review from stonebuzz and Rom1-B October 29, 2024 07:28
Rom1-B
Rom1-B requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK, can you get the customer to validate it?

@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz November 29, 2024 10:06
Rom1-B
Rom1-B reviewed Dec 17, 2024
View reviewed changes
inc/type.class.php Outdated Show resolved Hide resolved
@stonebuzz stonebuzz requested a review from Rom1-B December 26, 2024 11:55
Rom1-B
Rom1-B requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for customer feedback.

stonebuzz
stonebuzz requested changes Dec 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@stonebuzz stonebuzz self-requested a review December 26, 2024 14:21
stonebuzz
stonebuzz approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for customer feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B requested changes

@stonebuzz stonebuzz stonebuzz approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@MyvTsv MyvTsv

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MyvTsv @stonebuzz @Rom1-B