Skip to content

Commit

Permalink
Merge pull request bcgov#91 from poissonconsulting/main
Browse files Browse the repository at this point in the history
November package maintenance
  • Loading branch information
aazizish authored Nov 29, 2024
2 parents 12f1ad8 + cc58dde commit f6bdd14
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 3 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@
^joe-notes-0211\.rtf$
^COMPLIANCE\.yaml$
^\.github$
^TESTING\.md$
5 changes: 2 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: shinywqg
Title: Water Quality Guideline Shiny App
Version: 0.1.0
Version: 0.1.0.9000
Authors@R: c(
person("Sebastian", "Dalgarno", , "seb@poissonconsulting.ca", "aut", comment = c(ORCID = "0000-0002-3658-4517")),
person("Pearson", "Ayla", , "ayla@poissonconsulting.ca", c("aut", "cre"), comment = c(ORCID = "0000-0001-7388-1222")),
Expand Down Expand Up @@ -41,8 +41,7 @@ URL: https://github.com/bcgov/shinywqg
BugReports: https://github.com/bcgov/shinywqg/issues
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.3.1
RoxygenNote: 7.3.2
RdMacros: lifecycle
Language: en-US
VignetteBuilder: knitr
Roxygen: list(markdown = TRUE)
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!-- NEWS.md is maintained by https://fledge.cynkra.com, contributors should not edit this file -->

# shinywqg 0.1.0.9000 (2024-11-26)

- Package maintenance.
40 changes: 40 additions & 0 deletions TESTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Steps for manual testing of the app

This document is to guide developers on how to manually test the app.
Steps should be followed in order and be done in a single session from start to finish.

1. Open app: https://bcgov-env.shinyapps.io/bc_wqg/
2. Click on User Guide tab
a. Confirm formatting looks valid
3. Click on About tab
a. Confirm formatting looks valid
b. Check URLs are not broken
4. Confirm footer links are valid
5. Click on WQG tab
a. Click on download button
b. Select 1,1-Dicholoroethylene
i. Select Drinking water
1) Confirm results appears and are formatted correctly
2) Check links are active and correct
ii. Tick water off and on
1) Results should disappear if nothing ticked and then re-appear when ticked again
c. Select Copper by typing copper
i. Select Aquatic Life - Marine, Aquatic Life - Freshwater and Wildlife
ii. Confirm reports appear and are formatted correctly
1) Check links are active and correct
iii. Change Hardness value to 130
1) No change
iv. Change pH to 8
1) Should cause a guideline to change
v. Change Dissolved Organic Carbon to 2
1) Should cause guidelines changes
vi. Change Significant Figures to 2
1) Should drop decimal points (ie only whole numbers left)
vii. Change significant figures to 5
1) Should increase values to multiple decimal points
viii. Tick off water media
1) Parameter options should disappear
d. Select pH
i. Add all values
ii. Select a pH value of 1
1) Results should appear

0 comments on commit f6bdd14

Please sign in to comment.