Merge pull request #25 from poissonconsulting/ifelse2

Added informative error message to `if_else2()` if no matches are found
poissonconsulting · Oct 31, 2024 · 4973e9e · 4973e9e
2 parents 6c07e00 + 6a933df
commit 4973e9e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/R/if-else2.R b/R/if-else2.R
@@ -35,5 +35,8 @@
 #'   x3 = dplyr::if_else(str_detect2(y, "x is false"), FALSE, x)
 #' )
 if_else2 <- function(condition, true, false) {
+  if (!any(condition)) {
+    stop("No matches found. Did not make any replacements.")
+  }
   dplyr::if_else(condition, true, false, missing = false)
 }
diff --git a/tests/testthat/test-if-else2.R b/tests/testthat/test-if-else2.R
@@ -27,3 +27,11 @@ test_that("works with lists", {
     list(1, 2, NULL)
   )
 })
+
+test_that("throws an informative error when no matches are found", {
+  x <- c(1, 2, 3, 4, 5)
+  expect_error(
+    if_else2(x < 0, 0, x),
+    "No matches found. Did not make any replacements."
+  )
+})