Transferred duplicates() from poisdata
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylapear
requested changes
Jul 16, 2024
aylapear
approved these changes
Jul 17, 2024
joethorley
requested changes
Jul 24, 2024
There was a problem hiding this comment.
I think this is a great idea and like the name. However I think we should be use tidy evaluation so that the argument should be
duplicates(.data, ...)
so that we can call it as follows
duplicates(x, column1, anothercolumn)
It's probably worth looking to distinct for inspiration.
|
@dunkenwg I don't see any changes since the last review. Did you forget to push them? |
|
@aylapear I think I accidentally asked for your review. I'll work on this today and tomorrow and let you know if I get it done or run into any troubles. |
…ut arguments and follows tidy evaluation
`duplicates()` handles columns with missing values in a similar manner to `dplyr::distinct()`
- Added `.keep_all` argument to `duplicates()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicates()and associated tests from poisdata