URL with a path and credentials is not handled correctly

[msmania]

This is a fix for a regression introduced by 1766e70.

If a URL with a path is passed to JsonRpcProvider, the path is dropped when the provider makes a query because const url = new URL(route, finalRpcUrl); does drop the path in finalRpcUrl.

The proposed fix to create a URL first, and appends a path via string concat. This patch also adds a testcase for that logic.

[gitguardian]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9967853	Triggered	Base64 Basic Authentication	063a93e	packages/provider/tests/json-rpc-provider.test.ts	View secret
9967853	Triggered	Base64 Basic Authentication	122375b	packages/provider/tests/json-rpc-provider.test.ts	View secret
9967854	Triggered	Basic Auth String	063a93e	packages/provider/tests/json-rpc-provider.test.ts	View secret
9967854	Triggered	Basic Auth String	122375b	packages/provider/tests/json-rpc-provider.test.ts	View secret
9967854	Triggered	Basic Auth String	122375b	packages/provider/tests/json-rpc-provider.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[nodiesBlade]

lgtm

[msmania]

Thank you!