Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version to 2.2.0-rc.5 #106

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Update the version to 2.2.0-rc.5 #106

merged 1 commit into from
Mar 17, 2024

Conversation

msmania
Copy link
Contributor

@msmania msmania commented Mar 15, 2024

Why 2.2.0-rc.5?
Wanted to use 2.2.0-rc.0 first, but pocketjs-transaction-builder released 2.2.0-rc.3 two years ago. And 2.2.0-rc.4 was mistakenly published with npm instead of pnpm.

Why 2.2.0-rc.5?
Since pocketjs-transaction-builder released 2.2.0-rc.3 two years ago,
and 2.2.0-rc.4 was mistakenly published with npm instead of pnpm.
@msmania msmania requested a review from nodiesBlade March 15, 2024 00:56
@msmania msmania self-assigned this Mar 15, 2024
@msmania msmania added the dependencies Pull requests that update a dependency file label Mar 15, 2024
@@ -1,6 +1,6 @@
{
"name": "@pokt-foundation/pocketjs-monorepo",
"version": "2.2.1",
"version": "2.2.0-rc.5",
Copy link
Contributor

@nodiesBlade nodiesBlade Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we going from 2.2.1 -> 2.2.0?

Shouldn't it be either 2.3.0 or 2.2.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in code was 2.2.1, but the latest version published to NPM was 2.2.0-beta.0 and the latest tag of the repo is v2.1.1. It seems that v2.2.x was never published. I think v2.2.0 is the next version.

Copy link
Contributor

@nodiesBlade nodiesBlade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msmania msmania merged commit e36c639 into main Mar 17, 2024
3 of 4 checks passed
@msmania msmania deleted the toshi/version-2.2.0-rc.5 branch March 17, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants