Add outputAddress and rewardDelegators to the Node type #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodiesBlade
reviewed
Apr 5, 2024
nodiesBlade
reviewed
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the new fields
outputAddressandrewardDelegatorsto the typeNodeso thatJsonRpcProvider.getNodeandJsonRpcProvider.getNodesreturn all fields recorded in the blockchain.Since
JsonRpcProvider.getNodeswas implemented by 95f6cd3, there has been a bug thatgetNodesreturns the list of apps instead of nodes because the target path was wrong. This patch also fixes that bug too.