chore: ensure service module msg responses are non-empty

pokt-network · Dec 1, 2024 · 6c762ad · 6c762ad
1 parent 76d131c
commit 6c762ad
Show file tree

Hide file tree

Showing 5 changed files with 240 additions and 82 deletions.
diff --git a/api/poktroll/service/tx.pulsar.go b/api/poktroll/service/tx.pulsar.go
diff --git a/proto/poktroll/service/tx.proto b/proto/poktroll/service/tx.proto
@@ -72,5 +72,7 @@ message MsgAddService {
   poktroll.shared.Service service = 2 [(gogoproto.nullable) = false]; // The Service being added to the network
 }
 
-message MsgAddServiceResponse {}
+message MsgAddServiceResponse {
+  poktroll.shared.Service service = 1;
+}
 
diff --git a/x/service/keeper/msg_server_add_service.go b/x/service/keeper/msg_server_add_service.go
@@ -95,5 +95,7 @@ func (k msgServer) AddService(
 	k.SetService(ctx, msg.Service)
 
 	isSuccessful = true
-	return &types.MsgAddServiceResponse{}, nil
+	return &types.MsgAddServiceResponse{
+		Service: &msg.Service,
+	}, nil
 }
diff --git a/x/service/keeper/msg_server_add_service_test.go b/x/service/keeper/msg_server_add_service_test.go
@@ -43,11 +43,12 @@ func TestMsgServer_AddService(t *testing.T) {
 	keepertest.AddAccToAccMapCoins(t, oldServiceOwnerAddr, volatile.DenomuPOKT, oneUPOKTGreaterThanFee)
 
 	// Add the service to the store
-	_, err := srv.AddService(ctx, &types.MsgAddService{
+	addSvcRes, err := srv.AddService(ctx, &types.MsgAddService{
 		OwnerAddress: oldServiceOwnerAddr,
 		Service:      oldService,
 	})
 	require.NoError(t, err)
+	require.Equal(t, &oldService, addSvcRes.GetService())
 
 	// Validate the service was added
 	serviceFound, found := k.GetService(ctx, oldService.Id)