Skip to content

Commit

Permalink
Merge branch 'main' into full_node_docs_update
Browse files Browse the repository at this point in the history
  • Loading branch information
Olshansk authored Dec 5, 2024
2 parents c2a22ac + a9ad5e8 commit 9107add
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,25 @@ jobs:
fail_on_error: true
pattern: "TODO_UPNEXT:"

# TODO_TECHDEBT(@Olshansk): Consider removing or updating this check.
# It was originally added to avoid `sed` in helpers scripts and instructions
# to ensure compatibility across both Darwin &Linux. However, we then started
# writing Linux-only docs, leading to noise & false-positive.
#
# Prevent the use of `sed` in helper scripts. This ensures compatibility across
# Darwin and Linux systems.
check_sed:
name: Check sed
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pokt-network/action-fail-on-found@v1
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
level: error
fail_on_error: true
pattern: sed -i .*
# check_sed:
# name: Check sed
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: pokt-network/action-fail-on-found@v1
# with:
# github_token: ${{ secrets.github_token }}
# reporter: github-pr-review
# level: error
# fail_on_error: true
# pattern: sed -i .*

# Ensure that we are using polylog (via logger.) instead of the golang's stdlib
# log package.
Expand Down

0 comments on commit 9107add

Please sign in to comment.