Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clients] embed ParamsQuerier into ProofQueryClient #997

Draft
wants to merge 1 commit into
base: issues/543/params-querier/app
Choose a base branch
from
Draft

[Clients] embed ParamsQuerier into ProofQueryClient #997

wants to merge 1 commit into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 11, 2024 •
edited
Loading

Summary

Embed the ParamsQuerier interface into ProofQueryClient and update the implementation.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added off-chain Off-chain business logic code health Cleans up some code proof Claim & Proof life cycle labels Dec 11, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 11, 2024
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/app branch from b69d3d7 to 144004c Compare December 11, 2024 16:36
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from 603602e to d074fac Compare December 11, 2024 16:41
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/app branch from 144004c to 195073d Compare December 11, 2024 16:57
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from d074fac to bb9a3ab Compare December 11, 2024 17:10
@bryanchriswhite bryanchriswhite linked an issue Dec 11, 2024 that may be closed by this pull request
[Off-Chain] ModuleParamsClient & Historical Params #543
Open
4 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/app branch 3 times, most recently from f16b5f2 to 32be74f Compare December 13, 2024 14:33
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from bb9a3ab to 06c7c0b Compare December 13, 2024 14:38
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from 06c7c0b to c0f615c Compare December 13, 2024 15:10
@bryanchriswhite bryanchriswhite mentioned this pull request Jan 17, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bryanchriswhite bryanchriswhite

Labels
code health Cleans up some code off-chain Off-chain business logic proof Claim & Proof life cycle
Projects
Shannon
Status: 🏗 In progress
Milestone
Beta TestNet Iteration
Development

Successfully merging this pull request may close these issues.

[Off-Chain] ModuleParamsClient & Historical Params
1 participant
@bryanchriswhite