feat: generic DataFrame
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
force-pushed
the
feat/generic-dataframes
branch
2 times, most recently
from
ee1b921 to
adf2c51
Compare
scarf005
force-pushed
the
feat/generic-dataframes
branch
from
01bf949 to
0b83d6c
Compare
scarf005
force-pushed
the
feat/generic-dataframes
branch
from
0b83d6c to
e13e1f8
Compare
Bidek56
reviewed
Nov 18, 2024
| @@ -1314,8 +1314,8 @@ describe("dataframe", () => { | |||
| ]); | |||
| expect(actual).toFrameEqual(expected); | |||
| }); | |||
| test("pivot", () => { | |||
There was a problem hiding this comment.
Any reason for removing this? Thx
There was a problem hiding this comment.
gah, accidently removed when adding scopes, will amend and push again
EDIT: force-pushed on a675894 (#293)
Bidek56
reviewed
Nov 18, 2024
__tests__/dataframe.test.ts
Outdated
|
|
||
| df = pl.DataFrame({ | ||
| { |
There was a problem hiding this comment.
Any reason for these extra { } ? thx
There was a problem hiding this comment.
existing tests were failing as the type of DataFrame got more specific, so reassignment was failing due to type mismatch. thus i changed usage of let to const, and added {} for scope to prevent name collision of df, actual and expected. the changes are easier to see with whitespace disabled: https://github.com/pola-rs/nodejs-polars/pull/293/files?w=1
scarf005
force-pushed
the
feat/generic-dataframes
branch
from
e13e1f8 to
a675894
Compare
Bidek56
approved these changes
Nov 18, 2024
applied in |
universalmind303
approved these changes
Nov 21, 2024
|
thanks @scarf005 |
universalmind303
pushed a commit
that referenced
this pull request
Dec 17, 2024
Adding generic types to a few more methods beyond what was added in #293 by @scarf005 Focusing mostly on adding identity types to methods which I believe don’t change the original type of the dataframe. I added “identity” type signatures to the following methods: > extend, fillNull, filter, interpolate, limit, max, mean, median, min, quantile, rechunk, shiftAndFill, shrinkToFit, slice, sort, std, sum, tail, unique, var, vstack, where, upsample These previously returned `DataFrame<any>`, even when called on a well-typed DataFrame, but now return `DataFrame<T>` (the original type) --- I also added better types for a few slightly more complex ones: - map - improved return type based on the function passed, but unimproved parameter type - nullCount - toRecords - toSeries - for now, returning a broad union type, rather than identifying the specific column by index - withColumn --- Along the way, I added minor fixes for the types of: 1. `pl.intRange` [[1]](890bf21) which had overloads in the wrong order leading to incorrect return types, and 2. the `pl.Series(name, values, dtype)` constructor [[2]](a2635bd), whose strongly-typed overload was failing to apply in simple cases like `pl.Series("index", [0, 1, 2, 3, 4], pl.Int64)` when the input array used `number`s instead of `BigInt`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #292. please check individual commits for detail.