Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also does:
remove once_cell dependency;
deny missing_docs;
use output_type_func in derive/tests/01
NOTE: i can't get this to compile on my rig due to issues with rust-lld not finding some python symbols, not sure what's the deal with that, but you're welcome to try to build this on your machine and see how it works.
just wanted to push what i did so others could refer to it
this would enable support for pyo3 0.23.3 using
IntoPyObject
and fix all those deprecation warningsadditionally i added a lint,
#![deny(missing_docs)]
so the project won't compile with anything missing documentation, in my experience this aids accessibilityi had issues with
type_func=
in the derive crate, so i changed it tooutput_type_func
to make the compiler STFU, but i don't really know what that test was for; it's possible there has been some regression in the derive macro fortype_func
; please explainI'm not the best at checking github notifications and am in crunch time for a project release, so if you want edits to this PR, please go ahead and edit it!
would close
#124
#119
relevant to
#112
#37
cheers, happy new year, i'm personally trying to switch more to pure rust but am still using this sometimes so just wanted to contribute local changes upstream... please give me pointers if i screwed something up!