Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for pyo3 0.23.3; #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor for pyo3 0.23.3; #125

wants to merge 1 commit into from

Conversation

bionicles
Copy link

@bionicles bionicles commented Jan 2, 2025

also does:
remove once_cell dependency;
deny missing_docs;
use output_type_func in derive/tests/01

NOTE: i can't get this to compile on my rig due to issues with rust-lld not finding some python symbols, not sure what's the deal with that, but you're welcome to try to build this on your machine and see how it works.

just wanted to push what i did so others could refer to it

this would enable support for pyo3 0.23.3 using IntoPyObject and fix all those deprecation warnings

additionally i added a lint, #![deny(missing_docs)] so the project won't compile with anything missing documentation, in my experience this aids accessibility

i had issues with type_func= in the derive crate, so i changed it to output_type_func to make the compiler STFU, but i don't really know what that test was for; it's possible there has been some regression in the derive macro for type_func; please explain

I'm not the best at checking github notifications and am in crunch time for a project release, so if you want edits to this PR, please go ahead and edit it!

would close
#124
#119

relevant to
#112
#37

cheers, happy new year, i'm personally trying to switch more to pure rust but am still using this sometimes so just wanted to contribute local changes upstream... please give me pointers if i screwed something up!

@bionicles
Copy link
Author

regarding the note, it's possible my rust-lld not-finding-python issue is related to differences between our environments; i'm using miniconda3; seems you're using venv

one nice way to address these issues would be to put a Makefile in the root of the project with clear commands to set up the python environment. maybe i just didn't set some environment variable for rust-lld to find python? I definitely have python installed, so I'm not sure what's the deal

to best support windows, Justfile is potentially better cross-platform, as windows doesn't have Make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant