New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix csv download issue on windows #1292

Merged

eitsupi merged 1 commit into pola-rs:main from eitsupi:fix-windows-encoding-issue

Nov 19, 2024

Collaborator

eitsupi commented Nov 18, 2024 •

edited

Loading

The help of download.file says:

Code written to download binary files must use mode = "wb" (or "ab"), but the problems incurred by a text transfer will only be seen on Windows.


          fix: try to fix csv download issue on windows

3b24d55

eitsupi changed the title ~~fix: try to fix csv download issue on windows~~ fix: fix csv download issue on windows

eitsupi marked this pull request as ready for review

November 19, 2024 02:47

eitsupi merged commit a41515d into pola-rs:main

17 of 20 checks passed

eitsupi deleted the fix-windows-encoding-issue branch

November 19, 2024 03:34

etiennebacher mentioned this pull request

fix: Use "curl" to download CSV files on Windows #1291

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet