-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): improve search #925
Conversation
I understand. But I don't want to close #686 because this is not a fundamental solution. |
We can close #686 later, I've updated the initial post of this PR.
No because the search index is built on the Markdown files, which still have the |
I understand that. My point was that since $ is used in places such as examples, shouldn't that also be registered as a separator? |
I added it, it allows a bit more matches indeed |
Close #905
It seems that the
index.json
used for search cannot take into account pieces of words, e.gsum_hor
inpl_sum_horizontal
, which explains why the search results were so bad.This PR adds custom separators when building the
index.json
for search, meaning thatpl_
and other prefixes are no longer taken into account when looking for function names. Note that[\\s\\-]+
is the default, so only what comes after is customized.Here are some search suggestions before and after this change.
sum_horizontal
Old:
New:
strptime
Old:
New:
sink
Old:
New: