Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Simulate a Network #17

Merged
merged 11 commits into from
Sep 23, 2024
Merged

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Simulate a Network #17

merged 11 commits into from
Sep 23, 2024

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 10, 2024

The "Simulate a Network" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-blockchain/simulate-network/

@0xLucca 0xLucca requested a review from nhussein11 September 10, 2024 12:21
github-actions[bot]
github-actions bot reviewed Sep 10, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
@0xLucca 0xLucca added the B0 - Needs Review Pull request is ready for review label Sep 10, 2024
@0xLucca @nhussein11
Apply suggestions from code review
a6af261 
Co-authored-by: Nicolás Hussein <80422357+nhussein11@users.noreply.github.com>
@0xLucca
Copy link
Collaborator Author

0xLucca commented Sep 16, 2024

We could add one more section that runs all that was done in this guide with Zombienet. We could just link to the Zombienet page, show the commands that we execute, and that the network is up and running.

dawnkelly09
dawnkelly09 requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not run this for tech accuracy but, I did add some comments on formatting/Grammarly type stuff. Thanks!

tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 self-requested a review September 18, 2024 20:13
CrackTheCode016
CrackTheCode016 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the tutorial, working great

tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
0xLucca and others added 3 commits September 19, 2024 09:10
@0xLucca @dawnkelly09
Apply suggestions from code review
5ab4f93 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@0xLucca @dawnkelly09
Update tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md
4275ebf 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@0xLucca
Move node output to snippets
16de5ba
@0xLucca 0xLucca requested a review from dawnkelly09 September 19, 2024 14:10
eshaben
eshaben reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Outdated Show resolved Hide resolved
0xLucca and others added 2 commits September 23, 2024 10:28
@0xLucca
Snippet and command
fe6f874
@0xLucca @eshaben
Apply suggestions from code review
67f0926 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
github-actions[bot]
github-actions bot reviewed Sep 23, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/simulate-a-network.md Show resolved Hide resolved
@0xLucca @eshaben
Apply suggestions from code review
af18a47 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
eshaben
eshaben approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dawnkelly09
dawnkelly09 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work, all!

@eshaben eshaben merged commit 00fe38b into master Sep 23, 2024
1 check failed
@eshaben eshaben deleted the psdk-build-a-blockchain-1 branch September 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhussein11 nhussein11 nhussein11 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xLucca @eshaben @CrackTheCode016 @nhussein11 @dawnkelly09