Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polkadot Wiki Migration] Development Networks #18

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

DrW3RK
Copy link
Member

@DrW3RK DrW3RK commented Sep 10, 2024

List all of the development networks

Also add brief write up on developer journeys while using the testnets and testing tools

@DrW3RK DrW3RK self-assigned this Sep 10, 2024
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
@DrW3RK DrW3RK added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 17, 2024
@CrackTheCode016 CrackTheCode016 self-requested a review September 19, 2024 20:19
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM content wise besides some very minor nits

polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

@eshaben this is ready for you to review

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left some suggestions about linking to the Native Assets page (coming soon) to find out more info and where to get testnet tokens, let me know what ya think

polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested a review from eshaben September 27, 2024 15:51
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
dawnkelly09 and others added 3 commits October 1, 2024 14:21
@dawnkelly09 dawnkelly09 requested a review from eshaben October 1, 2024 18:26
@dawnkelly09 dawnkelly09 requested a review from eshaben October 3, 2024 18:32
@dawnkelly09 dawnkelly09 requested a review from a team as a code owner October 3, 2024 18:32
CrackTheCode016
CrackTheCode016 previously approved these changes Oct 3, 2024
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I would approve as is

polkadot-protocol/introduction/polkadot-networks.md Outdated Show resolved Hide resolved
Co-authored-by: bader y <ibnbassem@gmail.com>
@CrackTheCode016 CrackTheCode016 self-requested a review October 3, 2024 21:00
@CrackTheCode016 CrackTheCode016 merged commit 3e52340 into master Oct 3, 2024
@CrackTheCode016 CrackTheCode016 deleted the development-networks branch October 3, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants