-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github workflows #297
add github workflows #297
Conversation
@UtkarshBhardwaj007 It looks good to me I tried running this with act but I had the following issue: When running: act -W '.github/workflows/checks.yml' I get this error:
|
@0xLucca , that is strange. It works for me locally and it works here on this PR as well (you can see the checks running). It could be some local configuration issue. You need to specify the
Alternatively, can you share the verbose logging of your run (basically run the same command with the Either way, I think this is only related to being able to run the Github workflows locally (which is not part of this PR). I just did that extra step to confirm all commands were correct and running. Now that we have a PR, we can see that the workflows are running in this and should serve as a validation that the workflows work. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It is probably a local configuration issue, I'll check later but I don't want to hold this PR because of that. It is working on github so that's enough |
- '.snippets/code/**' | ||
- '.github/workflows/**' | ||
pull_request: | ||
types: [opened, synchronize, reopened, ready_for_review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the CI runs once when the PR is opened, when it receives a new commit, and when it is ready for review?
Perhaps it is good to remove ready_for_review
to reduce the number of runs a bit?
Or does this mean that if the PR is draft the CI won't run? that would be a good outcome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the CI runs once when the PR is opened, when it receives a new commit, and when it is ready for review?
Yes and also when a closed PR is re-opened.
Or does this mean that if the PR is draft the CI won't run? that would be a good outcome :)
Yes the CI won't run in draft mode. Once it is published, the CI would run. For, any commits after opening the PR, the CI would run as well which is ideal.
build
,test
andfmt
. These tests are largely inspired by what is already present in thepolkadot-sdk
.polkadot-sdk
repository for consistency.act
library with docker for local testing. Also the checks are running on this PR which should help.