fix: handle invalid high bits in ECRecover v value #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ECRecover precompile was already returning an empty vector for invalid v values, but the comment wasn't clear about handling high bits. This commit updates the comment to be more explicit about checking for any set high bits in the v value (bytes 32-62 must be 0) and that v (byte 63) can only be 27 or 28. Fixes TODO comment regarding "InvalidHighV-bits-1" test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECRecover precompile was already returning an empty vector for invalid v values, but the comment wasn't clear about handling high bits. This commit updates the comment to be more explicit about checking for any set high bits in the v value (bytes 32-62 must be 0) and that v (byte 63) can only be 27 or 28.
Fixes TODO comment regarding "InvalidHighV-bits-1" test case.