Changelog: Fix CI job and introduce verification CI job #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkchr
commented
Apr 19, 2024
bkchr
commented
- Does not require a CHANGELOG entry
bkchr
commented
Apr 20, 2024
muharem
approved these changes
Apr 28, 2024
muharem
reviewed
Apr 28, 2024
| @@ -59,7 +59,8 @@ jobs: | |||
| fi | |||
|
|
|||
| # Disable the spec version check when we dont want to release. | |||
| if ! .github/changelog-processor.py CHANGELOG.md --should-release ; then | |||
| # The program prints either `1` or `0`. | |||
| if [ "$(.github/changelog-processor.py CHANGELOG.md --should-release)" = "0" ]; then | |||
There was a problem hiding this comment.
andresilva
approved these changes
Jun 29, 2024
xlc
approved these changes
Jun 29, 2024
|
Review required! Latest push from author must always be reviewed |
andresilva
approved these changes
Jun 29, 2024
ggwpez
approved these changes
Jun 29, 2024
muharem
approved these changes
Jul 1, 2024
…-fellows/runtimes into bkchr-changelog-improvements-v2
andresilva
approved these changes
Jul 1, 2024
muharem
approved these changes
Jul 1, 2024
andresilva
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.