Fix whitelisted keys in benchmarks #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jan 3, 2025
acatangiu
approved these changes
Jan 3, 2025
Co-authored-by: Bastian Köcher <git@kchr.de>
|
Review required! Latest push from author must always be reviewed |
skunert
approved these changes
Jan 3, 2025
acatangiu
approved these changes
Jan 3, 2025
bkchr
approved these changes
Jan 3, 2025
|
/merge |
fellowship-merge-bot
bot
merged commit 685bfba
into
polkadot-fellows:main
48 of 51 checks passed
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whitelisted keys are manually set in
dispatch_benchmark. Actually pallet already declare the whitelisted keys, and it is missing many whitelist.in asset hub the key
relay_well_known_keys::ACTIVE_CONFIGis no longer whitelisted. It is actually only used in the relay chain palletconfiguration, and this pallet would whitelist the key if it was used. But asset hub doesn't use this pallet, so it doesn't need to whitelist the key.This PR will improve the benchmark precision, lower the cost of some calls.