[AHM] Improve accounts migration #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Jan 17, 2025
| <T as Config>::Currency::thaw(&freeze.id, &who) | ||
| // TODO: handle error | ||
| .unwrap(); | ||
| if let Err(e) = <T as Config>::Currency::thaw(&freeze.id, &who) { |
There was a problem hiding this comment.
Suggested change
| if let Err(e) = <T as Config>::Currency::thaw(&freeze.id, &who) { | |
| if let Err(e) = <T as Config>::Currency::thaw(&freeze.id, &who).defensive() { |
Then it also fails the test directly.
There was a problem hiding this comment.
there is actually defensive one level up if this function return an error
ggwpez
approved these changes
Jan 17, 2025
muharem
force-pushed
the
muharem-ahm-refine-accounts
branch
from
55b71ef to
eb0daaa
Compare
ggwpez
merged commit 5f2b139
into
polkadot-fellows:dev-asset-hub-migration
27 of 52 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to be merged into
dev-asset-hub-migrationbranch.Some improvements and fixes to the accounts migration.