Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link prefix for homepage #550

Closed
wants to merge 1 commit into from

Conversation

ericswpark
Copy link

If the user supplies a http/https prefix then the homepage link breaks because of it. Do not supply a prefix and let the user choose.

If the user supplies a http/https prefix then the homepage link breaks
because of it. Do not supply a prefix and let the user choose.
@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Nov 12, 2024
@OJFord
Copy link
Collaborator

OJFord commented Nov 19, 2024

Thanks, but dupe of #126.

@OJFord OJFord closed this Nov 19, 2024
@ericswpark
Copy link
Author

@OJFord do you know when it'll be merged (or if @posquit0 is maintaining this repo at all)? The PR seems to be stuck for the last 7 years...

@OJFord
Copy link
Collaborator

OJFord commented Nov 27, 2024

Posquit0 added me to help with the workload, but unfortunately I don't spend a lot of time on it either - I've had a couple of big clear outs and tried to stay on top of new requests (especially just closing down / moving to discussions) the spurious or unrelated stuff, which frankly is the bulk of it, but I haven't been able to get through a lot of the backlog of genuinely useful work or suggestions.

Since it seems the author there has moved on, I will either merge as is or apply my suggestion myself. I'm just always cautious to test manually any changes myself since I don't cause inadvertently 'breaking changes' (in this context really any changes to style or layout with existing use of the class unchanged) in people's CVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants