Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): fix invalid yaml syntax #3050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dumbasPL
Copy link

yaml values containing : need to be wrapped in quotes

The old example config would crash the app

yaml values containing `:` need to be wrapped in quotes

Signed-off-by: nezu <29180158+dumbasPL@users.noreply.github.com>
@willpower232
Copy link
Collaborator

Great spot, thanks!

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 18, 2024
@dumbasPL
Copy link
Author

hi?

@willpower232
Copy link
Collaborator

it is supposed to ignore things that have been labelled but apparently it doesn't work 👌

@dumbasPL
Copy link
Author

Is there a reason this isn't merged already? Am I missing something?

@willpower232
Copy link
Collaborator

The only thing missing is some available time from the actual mantainers who can make commits 😅

@catphish
Copy link
Contributor

This looks good to me, sorry for the delay in merging. I will try to test myself before actually merging but looks like an obvious fix.

@dtrckd
Copy link

dtrckd commented Nov 26, 2024

I confirm the fix works. Is there anything that prevent the merging ?

By the way, it seems there is another error in the config doc file.
It set a return_path:, but the correct value seems to actually be return_path_domain:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants