Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for JSON strings in data attributes #46

Closed
wants to merge 1 commit into from

Conversation

graemelambert
Copy link

Notable Changes

data-config='{"key": "val"}' currently gets changed to data-config="{"key": "val"}"

This pull request preserves the JSON structure rather than trying to convert the quotes.

Commit Message Summary (CHANGELOG)

Added support for JSON strings in data attributes

Type

ℹ️ What types of changes does your code introduce?

  • Fix

SemVer

ℹ️ What changes to the current semver range does your PR introduce?

  • Fix (:label: Patch)

Issues

ℹ️ What issue(s) (if any) are closed by your PR?

👉 Replace #1 with the issue number that applies and remove the `

Checklist

ℹ️ You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON in data attributes have double quotes converted to "
1 participant