Addressed minor comments

postmanlabs · Feb 16, 2024 · 99457c4 · 99457c4
1 parent 805b014
commit 99457c4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/collection/script.js b/lib/collection/script.js
@@ -64,6 +64,9 @@ _.assign(Script.prototype, /** @lends Script.prototype */ {
          */
         this.type = options.type || 'text/javascript';
 
+        /**
+         * @type {Object}
+         */
         this.packages = options.packages || {};
 
         _.has(options, 'src') && (

diff --git a/test/unit/collection.test.js b/test/unit/collection.test.js
@@ -25,8 +25,7 @@ describe('Collection', function () {
                         script: {
                             id: 'my-script-1',
                             type: 'text/javascript',
-                            exec: ['console.log("This doesn\'t matter");'],
-                            packages: {}
+                            exec: ['console.log("This doesn\'t matter");']
                         }
                     }]
                 },

diff --git a/test/unit/event-list.test.js b/test/unit/event-list.test.js
@@ -11,7 +11,7 @@ describe('EventList', function () {
             script: {
                 type: 'text/javascript',
                 exec: 'console.log("hello");',
-                packages: [{ id: 'script-package-1', name: 'package1' }]
+                packages: { package1: { id: 'script-package-1' } }
             }
         }];
 
@@ -49,7 +49,7 @@ describe('EventList', function () {
                     id: 'test-script-1',
                     type: 'text/javascript',
                     exec: ['console.log("hello");'],
-                    packages: { package1: { id: 'script-apckage-1' } }
+                    packages: { package1: { id: 'script-package-1' } }
                 }
             }]);
 
@@ -67,7 +67,7 @@ describe('EventList', function () {
                     id: 'test-script-1',
                     type: 'text/javascript',
                     exec: ['console.log("hello");'],
-                    packages: { package1: { id: 'script-apckage-1' } }
+                    packages: { package1: { id: 'script-package-1' } }
                 }
             });